<system_error>: Optimize internal class _System_error
#3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
system_error: Optimize internal class _System_error<system_error>: Optimize internal class _System_error
StephanTLavavej
approved these changes
Apr 7, 2023
|
Looks perfect, thank you! One note - in the future, we recommend avoiding force-pushing branches after creating PRs, because GitHub makes incremental reviewing difficult when this happens. |
Thanks for the tips here and on Discord |
AlexGuteniev
reviewed
Apr 8, 2023
strega-nil-ms
approved these changes
Apr 11, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving the performance of these constructors, and congratulations on your first microsoft/STL commit! 🚀 🎉 😻 This will ship in VS 2022 17.7 Preview 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, from a conversation that occurred on the STL Discord server, I noted that a call to ctor of the internal class
_System_errorappeared to take some extra unnecessary steps when the error message was empty.As suggested by Stephan I opened a pull request in an attempt to simplify the code.
The goal of this pull request is to skip entirely the call to the internal function
_Makestrsince it would have no effect on an empty string. I think my pull request does not have any unintended consequences. This is also my first contribution so please let me know if I messed something up. I have been lurking on the activity on this repo for a while and on the Discord server so I tried my best to follow the code conventions 😄