Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<algorithm>: ranges::minmax should dereference iterators only once #3366

Merged
merged 17 commits into from
Feb 3, 2023
Merged

<algorithm>: ranges::minmax should dereference iterators only once #3366

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
39689b4
fix ranges::minmax
fsb4000 Jan 27, 2023
f0b98f1
move last usage of `_Temp`
fsb4000 Jan 27, 2023
d5b9cdb
Unexpectedly Passed Tests
fsb4000 Jan 27, 2023
e993f4d
code review suggestions
fsb4000 Jan 28, 2023
a2cbb8b
add a comment about `if constexpr`
fsb4000 Jan 28, 2023
661b9bc
Merge branch 'main' into fix2900
StephanTLavavej Jan 30, 2023
c0abfa3
Code review feedback.
StephanTLavavej Jan 30, 2023
a06141a
add a test coverage for input iterators
fsb4000 Feb 1, 2023
2356ebf
Code review feedback, part 2.
StephanTLavavej Feb 1, 2023
15e4a13
unneeded moves
fsb4000 Feb 1, 2023
4886833
change `if constexpr` condition
fsb4000 Feb 1, 2023
2aff968
range_reference_t
fsb4000 Feb 1, 2023
b71f402
Clarify comment.
StephanTLavavej Feb 1, 2023
bc3262d
code review suggestions
fsb4000 Feb 2, 2023
fa6d225
wrong condition
fsb4000 Feb 2, 2023
8b96897
iterators that yield elements by value are fine
CaseyCarter Feb 2, 2023
efbb4d4
Nitpicks!
StephanTLavavej Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/algorithm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10104,8 +10104,8 @@ namespace ranges {
_STD move(_UFirst), _STD move(_ULast), _Pass_fn(_Pred), _Pass_fn(_Proj));
// Avoid repeatedly initializing objects from the result of an iterator dereference when doing so might
// not be idempotent. The `if constexpr` to avoid the extra branch in cases where it's not needed
StephanTLavavej marked this conversation as resolved.
Show resolved Hide resolved
if constexpr (same_as<remove_cvref_t<range_reference_t<_Rng>>, _Vty>
&& !is_lvalue_reference_v<range_reference_t<_Rng>>) {
if constexpr (!same_as<remove_cvref_t<range_reference_t<_Rng>>, _Vty>
|| !is_lvalue_reference_v<range_reference_t<_Rng>>) {
CaseyCarter marked this conversation as resolved.
Show resolved Hide resolved
if (_Found.min == _Found.max) {
fsb4000 marked this conversation as resolved.
Show resolved Hide resolved
// This initialization is correct, similar to WG21-N4928 [dcl.init.aggr]/6 example
StephanTLavavej marked this conversation as resolved.
Show resolved Hide resolved
minmax_result<_Vty> _Result = {static_cast<_Vty>(*_Found.min), _Result.min};
Expand Down