Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch <execution> #2662

Merged
merged 4 commits into from
May 1, 2022
Merged

Untag dispatch <execution> #2662

merged 4 commits into from
May 1, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 21, 2022 18:05
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Apr 21, 2022
@StephanTLavavej StephanTLavavej added throughput Must compile faster and removed enhancement Something can be improved labels Apr 21, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 27, 2022
@StephanTLavavej StephanTLavavej removed their assignment Apr 28, 2022
@StephanTLavavej
Copy link
Member

Wow, goodbye duplicated code and expensive SFINAE! 😻

@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit b0b9a58 into microsoft:main May 1, 2022
@StephanTLavavej
Copy link
Member

Thanks again for finding and if constexprizing this duplicated code! 😻 🎉 😻

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_execution branch May 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @raghavthind2005