Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parallel copy_backward() and move_backward() #2627

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Remove parallel copy_backward() and move_backward() #2627

merged 1 commit into from
Apr 4, 2022

Conversation

StephanTLavavej
Copy link
Member

Fixes #2626.

On Discord, @CaseyCarter additionally explained why these don't exist:

The only reason to use meow_backward over meow is to avoid aliasing issues when the head of the destination overlaps the tail of the source. Since the parallel algorithms all forbid overlapping, parallel meow_backward would be useless.

@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 30, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 30, 2022 19:42
CaseyCarter
CaseyCarter approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I double-checked that {copy,move}_backward truly do not appear in the discussion of the parallel algorithms in <yvals_core.h>.

@StephanTLavavej StephanTLavavej self-assigned this Apr 1, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2127ea0 into microsoft:main Apr 4, 2022
@StephanTLavavej StephanTLavavej deleted the meow-backward branch April 4, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsb4000 fsb4000 fsb4000 approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<xutility>: copy_backward() and move_backward() shouldn't have been parallelized
3 participants
@StephanTLavavej @CaseyCarter @fsb4000