-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize <xstring>
memmove function
#2055
Conversation
CI errors:
P.S. I doubt your PR will be accepted because |
…SVC fails despite it being the same but with a different style
I do not see any functional code change in product code. Please revert purely aesthetical changes |
Done |
<xstring>
memmove function
Gives the code a more consistent feel
Thanks for this simplification, and congratulations on your first microsoft/STL commit! 🚀 😺 This will ship in VS 2022 17.0 Preview 4. A note for the future: when pushing changes after reviewers have approved, it's a good idea to add a comment to the PR mentioning that you've done so, so the reviewers know to take another look. (Some changes that seem obviously desirable can be inconsistent with a coding convention, or can have surprising interactions with language complexity, etc. - which is why we're so careful about getting all changes to be seen by multiple reviewers.) Here, Casey and I had approved and moved this to Ready To Merge, and I wasn't looking closely for unannounced changes, so your last commit caught me by surprise. Fortunately Casey noticed and re-approved, so all was well (and I'm also fine with the change). This also happened before I mirrored the GitHub PR to the MSVC-internal repo, so no changes were dropped on the floor. I've now realized that we need to document these expectations better, so I'll add this to the Contribution Guidelines document that I need to write up. |
Optimized memmove