Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repairing counted_iterator #1939

Merged
merged 9 commits into from
Jun 29, 2021
Merged

Repairing counted_iterator #1939

merged 9 commits into from
Jun 29, 2021

Conversation

cpplearner
Copy link
Contributor

This implements the counted_iterator part of WG21-P2259.

Partially addresses #1684.

@cpplearner cpplearner requested a review from a team as a code owner May 29, 2021 00:58
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Jun 1, 2021
@CaseyCarter CaseyCarter self-assigned this Jun 9, 2021
CaseyCarter
CaseyCarter requested changes Jun 21, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a P2259R1 banner under "_HAS_CXX20 directly controls" in <yvals_core.h> with a partial completion indicator:

// P2259R1 Repairing Input Range Adaptors And counted_iterator
//     (partially implemented)

tests/std/tests/P0896R4_counted_iterator/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_counted_iterator/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_counted_iterator/test.cpp Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Jun 21, 2021
StephanTLavavej
StephanTLavavej reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll validate and push changes for const style and difference_type test coverage.

tests/std/tests/P0896R4_counted_iterator/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_counted_iterator/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Jun 24, 2021
@StephanTLavavej StephanTLavavej merged commit 1bfe5b1 into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing the Standard's usability fixes for ranges! 😻 🎉

@CaseyCarter CaseyCarter mentioned this pull request Aug 3, 2021
Merged
@cpplearner cpplearner deleted the patch-1 branch March 1, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpplearner @StephanTLavavej @CaseyCarter