Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coroutine promise types _must_ have member unhandled_exception in C++20 #1219

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Coroutine promise types _must_ have member unhandled_exception in C++20 #1219

merged 3 commits into from
Aug 26, 2020

Conversation

CaseyCarter
Copy link
Member

... even when _CPPUNWIND is not defined.

@CaseyCarter
promise types _must_ have unhandled_exception in C++20
91e7a0c 
.... even when `_CPPUNWIND` is not defined.
@CaseyCarter CaseyCarter added the bug Something isn't working label Aug 21, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner August 21, 2020 16:04
@CaseyCarter
VSO-967814 has been fixed
f4be83e 
... but VSO-1172852 remains, so we must keep the `exception_ptr` and rethrowing machinery in place for now. Let's annotate all of this workaround machinery properly, and demonstrate how to elide it after the bug is fixed.

Also avoid defining `unhandled_exception` in legacy coroutine mode when `_CPPUNWIND` isn't defined; legacy coroutines deal with this case in a different way that we don't want to regress.
@CaseyCarter
Apply suggestions from code review
268f3f8 
Fixup #else comments.
@CaseyCarter CaseyCarter requested a review from mnatsuhara August 24, 2020 23:42
@CaseyCarter CaseyCarter changed the title promise types _must_ have member unhandled_exception in C++20 Coroutine promise types _must_ have member unhandled_exception in C++20 Aug 24, 2020
@StephanTLavavej StephanTLavavej self-assigned this Aug 26, 2020
@StephanTLavavej StephanTLavavej merged commit 20fe376 into microsoft:master Aug 26, 2020
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug - it may be legacy/experimental tech, but a bug is a bug. 🪲 😺

@CaseyCarter CaseyCarter deleted the generator branch August 26, 2020 15:04
@kobykahane kobykahane mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@joemmett joemmett joemmett approved these changes

@GorNishanov GorNishanov GorNishanov approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CaseyCarter @StephanTLavavej @GorNishanov @joemmett @mnatsuhara