Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winapinls.cpp: Fuse nlsdownlevel.h and remove C idioms #188

Closed
StephanTLavavej opened this issue Oct 18, 2019 · 1 comment
Closed

winapinls.cpp: Fuse nlsdownlevel.h and remove C idioms #188

StephanTLavavej opened this issue Oct 18, 2019 · 1 comment
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

winapinls.cpp is the only file that includes nlsdownlevel.h. We should fuse them together and remove the C idioms.
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 18, 2019
@chris0x44
Copy link
Contributor

Hi there! Is this issue still available? If so, I'd like to take it.

chris0x44 pushed a commit to chris0x44/STL that referenced this issue Oct 25, 2019
Move nlsdownlevel.h into winapinls.cpp (microsoft#188)
27779bf
chris0x44 pushed a commit to chris0x44/STL that referenced this issue Oct 26, 2019
Move nlsdownlevel.h into winapinls.cpp (microsoft#188)
af36d45
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StephanTLavavej @chris0x44