<stack>, <queue>: Add std::forward for append_range (#5168)

microsoft · Dec 13, 2024 · 1a31980 · 1a31980
1 parent 2378c81
commit 1a31980
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/stl/inc/queue b/stl/inc/queue
@@ -126,8 +126,8 @@ public:
 #if _HAS_CXX23
     template <_Container_compatible_range<_Ty> _Rng>
     void push_range(_Rng&& _Range) {
-        if constexpr (requires { c.append_range(_Range); }) {
-            c.append_range(_Range);
+        if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
+            c.append_range(_STD forward<_Rng>(_Range));
         } else {
             _RANGES copy(_Range, back_insert_iterator{c});
         }
@@ -394,8 +394,8 @@ public:
     void push_range(_Rng&& _Range) {
         const size_type _Old_size = c.size();
 
-        if constexpr (requires { c.append_range(_Range); }) {
-            c.append_range(_Range);
+        if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
+            c.append_range(_STD forward<_Rng>(_Range));
         } else {
             _RANGES copy(_Range, back_insert_iterator{c});
         }

diff --git a/stl/inc/stack b/stl/inc/stack
@@ -111,8 +111,8 @@ public:
 #if _HAS_CXX23
     template <_Container_compatible_range<_Ty> _Rng>
     void push_range(_Rng&& _Range) {
-        if constexpr (requires { c.append_range(_Range); }) {
-            c.append_range(_Range);
+        if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
+            c.append_range(_STD forward<_Rng>(_Range));
         } else {
             _RANGES copy(_Range, back_insert_iterator{c});
         }