-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix link to reference #1263
Conversation
@sonichi, I do not think that my docs fix would break the code as the tests are failing now; it is coming from the master or some flaky cases? |
This looks an issue related to spark. @thinkall for awareness. |
seems that very same test are failing also on main branch so would be worse to check it to unblock all pending PRs |
Co-authored-by: Li Jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
- Coverage 71.72% 71.59% -0.13%
==========================================
Files 83 83
Lines 11249 11249
Branches 2360 2360
==========================================
- Hits 8068 8054 -14
- Misses 2726 2738 +12
- Partials 455 457 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi kindly reminder for review... 🐿️ |
Why are these changes needed?
it does not render as a link in the docs, see: https://microsoft.github.io/FLAML/docs/reference/default/greedy
Related issue number
Checks