Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridSplitter changes, rebased on top of OG GridSplitter PR #3
base: user/mhawker/gridsplitter
Are you sure you want to change the base?
GridSplitter changes, rebased on top of OG GridSplitter PR #3
Changes from 20 commits
76c947d
cfc2c57
4f18bc9
9f2c162
22b9c75
3f3f447
71de3f9
2e0dceb
a4c1ff3
41b7ec3
e79bcbc
6cc6213
da1cb5f
e805581
ed9e770
5cde5d4
5d09eb1
0121441
55d24b8
e5072bc
7c6f2c1
4962681
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: When removing the reliance upon the now-defunct
GripperHoverWrapper
class, this then allowed further refactoring, to where thisElement
property behaved more or less just like the frameworkContent
property, so I refactored theElement
property out.GridSplitter
settings, and would not introduce any breaking changes.GridSplitter
, this could break the customization after we remove thisElement
property.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if we can just use the default
Content
pattern, then that's going to be fine to remove the customElement
thing. :)