Skip to content

Commit

Permalink
doc: add missing step for llhttp update
Browse files Browse the repository at this point in the history
Refs: nodejs#43946

- Add instructions on updating llhttp version in
  file maintained only in Node.js repository as it
  needs to be kept in sync with what is copied from
  the llhttp repository when an update is made.

Signed-off-by: Michael Dawson <[email protected]>
  • Loading branch information
mhdawson committed Aug 23, 2022
1 parent 7900f65 commit 41e0d56
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions doc/contributing/maintaining-http.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ In order to update Node.js with a new version of llhttp:
* copy the contents of the `release` directory from the directory you
checked llhttp out to
[deps/llhttp](https://github.com/nodejs/node/tree/HEAD/deps/llhttp)
* update the llhttp version number in the project line in CMakeLists.txt
to match that set in include/llhttp.h

It should look like the following:

Expand Down

0 comments on commit 41e0d56

Please sign in to comment.