Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge metafacture-fix. #586

Open
wants to merge 1,080 commits into
base: master
Choose a base branch
from
Open

Merge metafacture-fix. #586

wants to merge 1,080 commits into from

Conversation

blackwinter
Copy link
Member

@blackwinter blackwinter commented Dec 13, 2024

Imported metafacture/metafacture-fix@b254549.

Resolves #577 (details outlined here).

dr0i and others added 30 commits December 13, 2022 11:24
Co-authored-by: Jens Wille <[email protected]>
- add tests
- add to README
This was overriding every defaultValue, but maps should have the possibility
to have different default values.
Fixes the "Failed to load class org.slf4j.impl.StaticLoggerBinder" message
when building.
Implementation against further tests from
#415 (comment).

- adapt some falsely Fix
- reuse test file "hcrt.ttl"
- one test tagged as "todo" because it needs introduction of new parameter
- reformat hcrt.ttl
- enable integration test
- add test

See #415.
- update README
- integrate lookup_rdf() into lookup()
- rename target_language to select_language (complements b49445d)
- remove comments in integrations test.fix for these are accounted to
This tests a redirected URL handled in org.metafacture.metafix.maps.RdfMap#read.
Tweak test: add blank inserted by `paste` as default `join_char`
…ogrammaticallyAddedValues

Fix issues caused by incomplete value paths
TobiasNx and others added 19 commits November 7, 2024 11:26
Gradle would produce the following error on Windows (while Linux is not affected):

"Cannot access input property 'classpath' of task ':metafix-runner:startScripts'. Accessing unreadable inputs or outputs is not supported. Declare the task as untracked by using Task.doNotTrackState(). For more information, please refer to https://docs.gradle.org/8.10.2/userguide/incremental_build.html#sec:disable-state-tracking in the Gradle documentation."
Co-authored-by: Jens Wille <[email protected]>
Ignore old value's path in `copy_field` Fix function.
Enables java logging. The log level can be changed by setting a variable.
Set and run like this:

export JAVA_OPTS="-Dorg.metafacture.metafix.logLevel=DEBUG"; ./gradlew installDist;  cd metafix-runner/build/install/metafix-runner; bin/metafix-runner $pathTo.flux

Note that you cannot use `./gradlew :metafix-runner:run ...` as setting
the log level only works within the distribution.

Co-authored-by: Jens Wille <[email protected]>
Optionally specify limit for number of entities in a record.
@blackwinter blackwinter requested review from fsteeg and dr0i December 13, 2024 15:48
@blackwinter blackwinter mentioned this pull request Dec 13, 2024
36 tasks
@blackwinter blackwinter marked this pull request as ready for review December 20, 2024 13:08
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@fsteeg fsteeg removed their assignment Jan 2, 2025
@TobiasNx
Copy link
Contributor

TobiasNx commented Jan 8, 2025

I tried to install the dist, it broke:

 ./gradlew installDist
Starting a Gradle Daemon, 2 incompatible Daemons could not be reused, use --status for details

> Configure project :
HEAD has no annotated tags
No SCM tag found. Making a snapshot build
Feature branch found
Version is feature-577-merge-metafacture-fix-SNAPSHOT

> Task :metafacture-runner:installDist FAILED
[Incubating] Problems report is available at: file:///home/tobias/git/metafacture-core/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':metafacture-runner:installDist'.
> The specified installation directory '/home/tobias/git/metafacture-core/metafacture-runner/build/install/metafacture-core' is neither empty nor does it contain an installation for 'metafacture-runner'.
  If you really want to install to this directory, delete it and run the install task again.
  Alternatively, choose a different installation directory.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.11.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 12s
89 actionable tasks: 2 executed, 87 up-to-date

@blackwinter
Copy link
Member Author

So have you tried deleting the directory?

The specified installation directory '/home/tobias/git/metafacture-core/metafacture-runner/build/install/metafacture-core' is neither empty nor does it contain an installation for 'metafacture-runner'.
If you really want to install to this directory, delete it and run the install task again.
Alternatively, choose a different installation directory.

Also, could you document the functional review in the issue instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

Include metafacture-fix
5 participants