-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge metafacture-fix. #586
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jens Wille <[email protected]>
- add tests - add to README
This was overriding every defaultValue, but maps should have the possibility to have different default values.
Fixes the "Failed to load class org.slf4j.impl.StaticLoggerBinder" message when building.
Implementation against further tests from #415 (comment). - adapt some falsely Fix - reuse test file "hcrt.ttl" - one test tagged as "todo" because it needs introduction of new parameter - reformat hcrt.ttl
- enable integration test - add test See #415.
- update README - integrate lookup_rdf() into lookup() - rename target_language to select_language (complements b49445d) - remove comments in integrations test.fix for these are accounted to
This tests a redirected URL handled in org.metafacture.metafix.maps.RdfMap#read.
Tweak test: add blank inserted by `paste` as default `join_char`
Add integration test for #278
…ogrammaticallyAddedValues Fix issues caused by incomplete value paths
Gradle would produce the following error on Windows (while Linux is not affected): "Cannot access input property 'classpath' of task ':metafix-runner:startScripts'. Accessing unreadable inputs or outputs is not supported. Declare the task as untracked by using Task.doNotTrackState(). For more information, please refer to https://docs.gradle.org/8.10.2/userguide/incremental_build.html#sec:disable-state-tracking in the Gradle documentation."
…hub.com:metafacture/metafacture-fix
- add test - update README
Co-authored-by: Jens Wille <[email protected]>
Co-authored-by: Jens Wille <[email protected]>
Complements 9014b01.
Ignore old value's path in `copy_field` Fix function.
Enables java logging. The log level can be changed by setting a variable. Set and run like this: export JAVA_OPTS="-Dorg.metafacture.metafix.logLevel=DEBUG"; ./gradlew installDist; cd metafix-runner/build/install/metafix-runner; bin/metafix-runner $pathTo.flux Note that you cannot use `./gradlew :metafix-runner:run ...` as setting the log level only works within the distribution. Co-authored-by: Jens Wille <[email protected]>
Optionally specify limit for number of entities in a record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
I tried to install the dist, it broke:
|
So have you tried deleting the directory?
Also, could you document the functional review in the issue instead? |
Imported metafacture/metafacture-fix@b254549.
Resolves #577 (details outlined here).