Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating documentation to show how to use the plugin dynamically. #3679

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Updating documentation to show how to use the plugin dynamically. #3679

merged 8 commits into from
Apr 6, 2023

Conversation

thephpguy
Copy link
Contributor

Previously there was an example of how to use the plugin dynamically. That documentation was wrong/outdated and was removed.

@thephpguy thephpguy requested a review from a team as a code owner April 1, 2023 14:34
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4f4d2e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2023

@thephpguy is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@thephpguy
Copy link
Contributor Author

closes #3678

shahednasser
shahednasser requested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephpguy thank you for your contribution! Can you instead add this to the documentation? Specifically the file at docs/content/plugins/notifications/sendgrid.mdx

@thephpguy thephpguy requested a review from a team as a code owner April 3, 2023 13:42
shahednasser
shahednasser requested changes Apr 3, 2023
View reviewed changes
docs/content/plugins/notifications/sendgrid.mdx Outdated Show resolved Hide resolved
packages/medusa-plugin-sendgrid/README.md Outdated Show resolved Hide resolved
@thephpguy thephpguy requested a review from shahednasser April 4, 2023 01:58
shahednasser
shahednasser reviewed Apr 4, 2023
View reviewed changes
docs/content/plugins/notifications/sendgrid.mdx Outdated

You can resolve the SendGrid service to send emails from your custom services or other resources. For example:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to mention this before, but can you add the language here ts? You might also need to run the command yarn lint:docs --fix to resolve any eslint errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Missed that. Thanks.

@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Apr 4, 2023 6:45am

@shahednasser shahednasser changed the base branch from master to develop April 6, 2023 08:11
shahednasser
shahednasser approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for your contribution 🚀

@shahednasser shahednasser merged commit 16f73ba into medusajs:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thephpguy @shahednasser