Use buffer module which support node.js and browser

[xxkl1]

The Wepack5 haven't provided polyfills for node.js core modules, and Vite does't suppot polyfill for buffer.

It will occur error on browser using the Wepack5 and Vite.

Because of the Browserify have used buffer polyfill, it is fine on browser.

I would suggest using buffer polyfill by add npm module buffer like Browserify.

link: #9 (comment)

reproduction:
Webpack5: https://stackblitz.com/edit/node-yctv93?file=src%2Findex.js,package.json
Vite: https://stackblitz.com/edit/node-bedrwr?file=package.json

[mcollina]

Suggested change

	const Buffer = require('buffer/').Buffer
	const Buffer = require('buffer/').Buffer

Please use the global Buffer object if it is available

[xxkl1]

function loadBuffer () {
  const b = require('buffer')
  // use third party module if no Buffer module
  return b
    ? b.Buffer
    : require('buffer/').Buffer
}

I have added a function to load Buffer, please review my new commit if have time.

[DanielRuf]

Why was this closed?

[mcollina]

thiw now conflicts

[mcollina]

lgtm

[mcollina]

This should really include a test

[xxkl1]

This should really include a test

Let me think about how to add test for this case.

[mcollina]

closing for no activity