Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure taggings context aliases are maintained when joining taggings #589

Merged
merged 1 commit into from
Sep 16, 2014

Conversation

markedmondson
Copy link
Contributor

Using stringified conditions means that the table aliasing fails with joins to multiple taggables

Test and patch included

Ref #273

seuros added a commit that referenced this pull request Sep 16, 2014
Ensure taggings context aliases are maintained when joining taggings, fixes #273
@seuros seuros merged commit 10b8dfe into mbleigh:master Sep 16, 2014
@seuros
Copy link
Collaborator

seuros commented Sep 16, 2014

Thanks you

tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Ensure taggings context aliases are maintained when joining taggings, fixes mbleigh#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants