Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 318 update devices info #321

Merged

Conversation

ascherbinin
Copy link
Contributor

Updated all devices sections

  • Update iPhone section
  • Update iPad section
  • Update iPod section
  • Update AppleTV section
  • Update Apple Watch section

@brototyp-bot
Copy link

brototyp-bot commented Sep 22, 2019

1 Warning
⚠️ Are there any changes that should be explained in the README.md?

Generated by 🚫 Danger

Copy link
Member

@brototyp brototyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Just one small comment.

MatomoTracker/Device.swift Show resolved Hide resolved
@brototyp
Copy link
Member

@ascherbinin Great. Thank you! I just left a comment in the diff.

Also: Can you add an entry to the CHANGELOG.md?

@ascherbinin
Copy link
Contributor Author

@ascherbinin Great. Thank you! I just left a comment in the diff.

Also: Can you add an entry to the CHANGELOG.md?

Added entry for version 7.0.3

@brototyp
Copy link
Member

Awesome. Looks great! Thanks a lot!

@brototyp brototyp merged commit aea2be4 into matomo-org:develop Sep 24, 2019
@brototyp
Copy link
Member

brototyp commented Nov 6, 2019

This was just released in version 7.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants