Write a test for setting the hostmask when nick is in use #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,7 +124,8 @@ function Client(server, nick, opt) { | |||
| // include it in messages and will truncate what we send if | |||
| // the string is too long. Therefore, we need to be considerate | |||
| // neighbors and truncate our messages accordingly. | |||
| self.hostMask = message.args[message.args.length - 1]; | |||
| var welcomeStringWords = message.args[1].split(/ /); | |||
There was a problem hiding this comment.
/\s+/ might be a better split pattern
... and while here, fix the hostmask calculation. It was using the length of the message rather than the last part, therefore wrapping incorrectly and storing the incorrect hostname.
|
+1 |
ghost
pushed a commit
that referenced
this pull request
Jan 12, 2015
Write a test for setting the hostmask when nick is in use
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and while here, fix the hostmask calculation. It was using
the length of the message rather than the last part, therefore
wrapping incorrectly and storing the incorrect hostname.