Fixed irc not connecting to selfsigned servers #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified this patch and I can now login to irc servers with selfsigned certificates, @antonva thanks! |
osslate
pushed a commit
that referenced
this pull request
May 29, 2014
fixed connecting to self-signed servers
|
Curious, is the fingerprint of the cert for the connection readily accessible? Slightly unrelated thought: Should a certificate pinning mechanism be added to the library? |
|
@damianb In the future, people will be responsible for SSL connections, not the library. The way things are at now isn't ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even when self.opt.selfSigned is true.