Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CHANMODES when modifying channel modes #145

Closed
wants to merge 2 commits into from

Conversation

awwright
Copy link

@awwright awwright commented Feb 2, 2013

This commit enhances how channel modes are set, and should be free of any TypeError errors. It also creates a new Function Channels since that's the most efficient way of creating multiple Objects with the same properties, and adds a method to set that channel's mode, emitting events as necessary if there is an associated message to emit with.

Closes #144.

@awwright
Copy link
Author

awwright commented Feb 2, 2013

This by itself still appears to create errors. Await some more commits before pulling.

I also need to add support for banlist, etc replies from the server. Not sure how to do that since the numeric replies may not be standardized.

@awwright
Copy link
Author

awwright commented Feb 5, 2013

Alright this appears to fix most everything. If there's Errors being emitted then there's other bugs, possibly with the IRC server itself, which should get their own issue.

@awwright awwright mentioned this pull request May 6, 2014
@osslate osslate closed this May 29, 2014
@ghost
Copy link

ghost commented Jan 6, 2015

@ACubed Do you know why @expr closed this?

@awwright
Copy link
Author

awwright commented Jan 6, 2015

@apeiron I didn't even know it was closed >:|

@expr is there any way I can help fix #144, #222?

@ghost
Copy link

ghost commented Jan 6, 2015

@ACubed Additionally, how does this improve upon #222?

@awwright
Copy link
Author

awwright commented Jan 6, 2015

@apeiron The server defines which modes are "channel" modes, they're not hard-coded into IRC. #222 would serve to fix some servers and break others.

@ghost ghost reopened this Jan 6, 2015
@@ -123,7 +123,6 @@ function Client(server, nick, opt) {
value = value.split(',');
var type = ['a','b','c','d']
for (var i = 0; i < type.length; i++) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: remove this empty line.

@ghost
Copy link

ghost commented Jan 6, 2015

@ACubed Can you update this so it will merge cleanly, and we can revisit it?

@awwright
Copy link
Author

awwright commented Jan 6, 2015

@apeiron What am I supposed to merge this with? The irc.js file (and most all the logic) is completely gone in master. Was there a rewrite?

@ghost
Copy link

ghost commented Jan 6, 2015

We're currently developing on the 0.3.x branch; the README has
been updated ot that fact. Sorry for the confusion!

@awwright
Copy link
Author

awwright commented Jan 6, 2015

New branch pulled in #270

@awwright awwright closed this Jan 6, 2015
@awwright
Copy link
Author

awwright commented Jan 7, 2015

Reopen for master branch.

There's a craptonne more merge conflicts, I'll essentially have to re-write the code it looks like.

@awwright
Copy link
Author

awwright commented Jan 7, 2015

I can't seem to reopen this. GitHub, halp

@ghost
Copy link

ghost commented Jan 7, 2015

That's odd. I get "Something went wrong with that request. Please try again."

@ghost ghost reopened this Jan 23, 2015
@ghost ghost added the needs-rebase label Jan 23, 2015
@ghost
Copy link

ghost commented Jan 23, 2015

@ACubed I have spoken with Github support and they deployed a fix to allow me to re-open this pull request. You'll need to (rebase)[https://github.com/martynsmith/node-irc/wiki/0.3.x-branch-debacle] the pull request. Thank you!

@Timer Timer mentioned this pull request Apr 14, 2015
@awwright
Copy link
Author

Closing because it appears this was fixed in #351

@awwright awwright closed this Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain MODE messages could access on undefined
2 participants