-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CHANMODES when modifying channel modes #145
Conversation
This by itself still appears to create errors. Await some more commits before pulling. I also need to add support for banlist, etc replies from the server. Not sure how to do that since the numeric replies may not be standardized. |
Alright this appears to fix most everything. If there's Errors being emitted then there's other bugs, possibly with the IRC server itself, which should get their own issue. |
@@ -123,7 +123,6 @@ function Client(server, nick, opt) { | |||
value = value.split(','); | |||
var type = ['a','b','c','d'] | |||
for (var i = 0; i < type.length; i++) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: remove this empty line.
@ACubed Can you update this so it will merge cleanly, and we can revisit it? |
@apeiron What am I supposed to merge this with? The irc.js file (and most all the logic) is completely gone in master. Was there a rewrite? |
We're currently developing on the |
Conflicts: lib/irc.js
New branch pulled in #270 |
Reopen for master branch. There's a craptonne more merge conflicts, I'll essentially have to re-write the code it looks like. |
I can't seem to reopen this. GitHub, halp |
That's odd. I get "Something went wrong with that request. Please try again." |
@ACubed I have spoken with Github support and they deployed a fix to allow me to re-open this pull request. You'll need to (rebase)[https://github.com/martynsmith/node-irc/wiki/0.3.x-branch-debacle] the pull request. Thank you! |
Closing because it appears this was fixed in #351 |
This commit enhances how channel modes are set, and should be free of any TypeError errors. It also creates a new Function Channels since that's the most efficient way of creating multiple Objects with the same properties, and adds a method to set that channel's mode, emitting events as necessary if there is an associated message to emit with.
Closes #144.