Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIRC Support #427

Closed
ghost opened this issue Nov 3, 2015 · 10 comments
Closed

WebIRC Support #427

ghost opened this issue Nov 3, 2015 · 10 comments

Comments

@ghost
Copy link

ghost commented Nov 3, 2015

I need to add WebIRC Support to our node-irc usage. We have built a webchat that connects to our IRC network but the problem is that we now have 100's of users connecting by the web server IP address and not their real IP address.

Before the client sends the PASS, USER or NICK commands it should send:

WEBIRC password user hostname ip

How can I hook in to node-irc so that before it sends the PASS, USER or NICK commands it sends another command?

@ghost
Copy link

ghost commented Nov 3, 2015

Please read/try the docs here. ask questions on channel ##node-irc (freenode) i idle frequently there.

@ghost
Copy link
Author

ghost commented Nov 3, 2015

@jnull so if I hook in to 'registered', will my line definitely be sent after it has received the 001 numeric and before PASS, USER or NICK commands?

@ghost
Copy link
Author

ghost commented Nov 3, 2015

Just realised this is already implemented but isn't mentioned in the documentation. lib/irc.js shows the configuration options and relevant code.

@ghost
Copy link

ghost commented Nov 3, 2015

@ircer What is already implemented? Did you find your solution?

@ghost
Copy link
Author

ghost commented Nov 4, 2015

@jnull WebIRC Support, what this ticket is about!

https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L59-L64 are the relevant configuration lines.

It would help if this was mentioned in the documentation, so that people don't waste time implementing something that is already supported.

@ghost ghost closed this as completed Nov 4, 2015
@ghost
Copy link
Author

ghost commented Nov 4, 2015

However small bug in that linked code however.

https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L639 wants this.opt.webirc.host but https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L59-L62 gives user.

https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L62 needed to be changed from user to host and it works fine.

@ghost ghost reopened this Nov 4, 2015
@moshmage
Copy link

moshmage commented Nov 5, 2015

@ircer maybe PR that fix in?

@ghost
Copy link
Author

ghost commented Nov 6, 2015

@moshmage done.

@ghost
Copy link
Author

ghost commented Nov 8, 2015

Any update on getting it merged then?

@moshmage
Copy link

moshmage commented Nov 9, 2015

@ghost MR are coming in slow, @jirwin knows more about that

@jirwin jirwin closed this as completed in c70d951 Jan 28, 2016
jirwin added a commit that referenced this issue Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant