Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump earcut from 3.0.0 to 3.0.1 #13371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump earcut from 3.0.0 to 3.0.1 #13371

wants to merge 1 commit into from

Conversation

huanglii
Copy link

@huanglii huanglii commented Dec 25, 2024

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@huanglii huanglii requested a review from a team as a code owner December 25, 2024 03:58
@CLAassistant
Copy link

CLAassistant commented Dec 25, 2024

CLA assistant check
All committers have signed the CLA.

@mourner
Copy link
Member

mourner commented Dec 25, 2024

Looks like the new Earcut version is failing some render tests — will need investigation so let's hold off on upgrading for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants