Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openal-soft: fix build on 10.4-10.6 #12732

Closed
wants to merge 1 commit into from

Conversation

evanmiller
Copy link
Contributor

Description

patch-openal-soft-coreaudio.diff adapted from @kencu's TigerPorts. The other additions are mine.

$ openal-info
Available playback devices:
    CoreAudio Default
Available capture devices:
    CoreAudio Default
Default playback device: CoreAudio Default
Default capture device: CoreAudio Default
ALC version: 1.1

** Info for device "CoreAudio Default" **
ALC version: 1.1
ALC extensions:
    ALC_ENUMERATE_ALL_EXT, ALC_ENUMERATION_EXT, ALC_EXT_CAPTURE,
    ALC_EXT_DEDICATED, ALC_EXT_disconnect, ALC_EXT_EFX,
    ALC_EXT_thread_local_context, ALC_SOFT_device_clock, ALC_SOFT_HRTF,
    ALC_SOFT_loopback, ALC_SOFT_loopback_bformat, ALC_SOFT_output_limiter,
    ALC_SOFT_pause_device
Available HRTFs:
    Built-In HRTF
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.4.11 8S165 Power Macintosh
Component versions: DevToolsCore-798.0; DevToolsSupport-794.0

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

Patches adapted from @kencu's TigerPorts
@macportsbot macportsbot added maintainer: open Affects an openmaintainer port type: bugfix labels Oct 30, 2021
@mascguy mascguy self-assigned this Oct 30, 2021
@macports macports deleted a comment from macportsbot Oct 30, 2021
@ryandesign
Copy link
Contributor

Looks reasonable, however I may not have the energy to update this patch if a future update of openal-soft makes incompatible changes in the patched files. You may become responsible for maintaining this patch and/or the port if that happens, or rather, I may stop updating it and it will be left to you or anyone else to do so.

Ideally the patch should be submitted to the developers of openal-soft so that they can incorporate it into their code and then everyone can benefit, not just MacPorts users, and then we won't have problems with having to maintain the patch forever.

@evanmiller
Copy link
Contributor Author

@ryandesign Happy to leave this open and pitch the patches upstream if you'd rather not deal with the extra maintenance here.

(I'm not particularly interested in this port; just trying to upstream what I can out of Ken's now-404 TigerPorts repo...)

@evanmiller
Copy link
Contributor Author

Upstream PR for the dispatch diff: kcat/openal-soft#610

If it goes well I'll see about upstreaming the CoreAudio changes. The AudioComponent stuff could also be a good candidate for inclusion in LegacySupport.

@evanmiller evanmiller marked this pull request as draft November 11, 2021 03:56
@evanmiller
Copy link
Contributor Author

Converting to Draft while the semaphore issue is discussed upstream

@reneeotten
Copy link
Contributor

ping @evanmiller / @ryandesign is there a plan on what to do with this PR? If this port is currently broken on 10.4 - 10.6 can we just restrict the proposed changes to this old systems and get this incorporated? It seem like limited risk and from the link above it doesn't seem like the discussion with upstream has made any progress? If the conclusion is that this will not be merged anyway, please close the PR and keep the queue clean.

@evanmiller
Copy link
Contributor Author

After further discussion even further upstream (GCC) there appear to be blocking issues with the C++ run-time. I will close this PR until those are resolved.

@evanmiller evanmiller closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants