Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing ec2-instance-count to start multiple runners #165

Closed
wants to merge 2 commits into from
Closed

Conversation

dexbleeker
Copy link

Fixes #8

This PR is based on the fork of @messense, specifically this commit.

It allows for providing ec2-instance-count as input variable and will start multiple runners if desired. By default 1 runner is started.

Note that this might not be the cleanest code or best implementation. I don't write JS generally and have not touched a GH action before. Especially Array.from(JSON.parse(ec2InstanceIds)) feels wrong.

All feedback is welcome however.

@mickmorse
Copy link

Works like a charm

@machulav 👀

@mickmorse
Copy link

Only comments are to update the readme surrounding the outputs and examples (with it now being ec2-instance-ids)

@wu-json
Copy link

wu-json commented Oct 13, 2023

Any plans to merge this?

@Dmitry1987
Copy link

MinCount/MaxCount are not used anywhere, shouldn't it be a specific count, why there's a min/max, kind of "if at least N will successfully be created" ?
a useful feature for me too, i wonder why won't be merged :(

@thimios
Copy link

thimios commented Mar 28, 2024

+1 Very useful feature for us too.

@Innico Innico closed this by deleting the head repository May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start multiple runners for processing a couple of jobs in parallel
6 participants