Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Store captured pieces as part of the move #604

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Jan 13, 2024

Calculate captured piece on move generation instead of (potentially) doing twice t on Score() and Make() methods (ab1cbfd)

Not enough by itself

Elo   | -5.12 +- 7.00 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.31 (-2.25, 2.89) [0.00, 5.00]
Games | N: 6034 W: 1881 L: 1970 D: 2183
Penta | [298, 664, 1122, 695, 238]
https://openbench.lynx-chess.com/test/88/

Replace Position.PieceAt() usage with move.CapturedPiece() (a8d5769)

Now we're talking

Score of Lynx-move-encode-captured-piece-2393-win-x64 vs Lynx 2392 - main: 4145 - 3926 - 4762  [0.509] 12833
...      Lynx-move-encode-captured-piece-2393-win-x64 playing White: 2825 - 1248 - 2344  [0.623] 6417
...      Lynx-move-encode-captured-piece-2393-win-x64 playing Black: 1320 - 2678 - 2418  [0.394] 6416
...      White vs Black: 5503 - 2568 - 4762  [0.614] 12833
Elo difference: 5.9 +/- 4.8, LOS: 99.3 %, DrawRatio: 37.1 %
SPRT: llr 2.9 (100.3%), lbound -2.25, ubound 2.89 - H1 was accepted

@eduherminio eduherminio changed the title ⚡ Stored captured pieces as part of the move ⚡ Store captured pieces as part of the move Jan 13, 2024
@eduherminio eduherminio marked this pull request as ready for review January 13, 2024 16:06
@eduherminio eduherminio enabled auto-merge (squash) January 13, 2024 20:21
@eduherminio eduherminio merged commit c6e0d10 into main Jan 13, 2024
21 checks passed
@eduherminio eduherminio deleted the move-encode-captured-piece branch January 13, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant