-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔍 Add Reverse Futility Pruning (RFP) #382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 57d0dc4.
Prefer the former, in case the condition is not true and we can avoid evaluating the second one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
0bf9142: MaxDepth 6, Scaling factor 75
8+0.08 👍🏽 56.1 +/- 18.8 vs main (1414)
Overview (8+0.08, 8moves_v3):
dc77eca: MaxDepth 4, Scaling factor 150
8+0.08 👍🏽 41.0 +/- 15.9 vs main (1414)
37a6f10: MaxDepth 8, Scaling factor 100
8+0.08 👍🏽 41.5 +/- 16.0 vs main (1414)
6a0c6ec: MaxDepth 6, Scaling factor 100
8+0.08 👍🏽 46.1 +/- 16.9 vs main (1414)
0bf9142: MaxDepth 6, Scaling factor 75
8+0.08 👍🏽 56.1 +/- 18.8 vs main (1414)
Taking 4 150 as base (1427):
f1b5504: MaxDepth 2, Scaling factor 150
8+0.08 👎🏽vs 4 150 (1427)
bc78727: MaxDepth 6, Scaling factor 100
8+0.08 👍🏽 12.0 +/- 7.9 vs 4 150 (1427)
6ce48d9: MaxDepth 8, Scaling factor 150
8+0.08 vs 4 150 (1427)
Taking 6 100 as base (1430):
0bf9142: MaxDepth 6, Scaling factor 75
8+0.08 👍🏽 5.8 +/- 4.6 vs 6 100 (1430)
03dc994: MaxDepth 8, Scaling factor 100
8+0.08 3.8 +/- 4.4 (abandoned to test vs 6 75), looking like potential small gain vs 6 100 (1430)
Taking 6 75 as base (1431/1440):
0c7bf16: MaxDepth 8, Scaling factor 75
8+0.08 👎🏽 -5.5 +/- 7.2, looking like potential small gain vs 6 100 (1431)
6ea5bb9: MaxDepth 8, Scaling factor 100
8+0.08 👎🏽 -1.8 +/- 5.3 vs 6 75 (1431)
436e350: RFP before NMP (1442):
8+0.08 👎🏽 -4.8 +/- 6.9 vs 6 75 (1440)
1616e1c: Avoid RFP re-evaluation in case of NMP evaluating back
8+0.08 👎🏽 vs 6 75 (1440)
609dce9: beta condition
8+0.08 👎🏽
Wrong impl, inside of move loop
pre-psqt:011dd9c: MaxDepth 4, Scaling factor 150
8+0.08 👎🏽 vs v0.16.0 (no psqt)
post-psqt:
0a832b8: MaxDepth 2, Scaling factor 300
8+0.08 👎🏽 vs main (1399)
b361e36: MaxDepth 4, Scaling factor 150
8+0.08 👎🏽 vs main (1399)
382c41e: MaxDepth 6, Scaling factor 100
8+0.08 👎🏽 (aborted) vs main (1399)
: MaxDepth 8, Scaling factor 75
8+0.08 👎🏽 vs main (1399)