Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Force TT array to have a power of two length #349

Merged
merged 12 commits into from
Aug 16, 2023
Merged

⚡ Force TT array to have a power of two length #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d694b7
Round up TT length to a power of 2 replace `zobrist % length` with `z…
eduherminio Aug 16, 2023
a1212d9
Add missing using
eduherminio Aug 16, 2023
949f502
Add benchmark results
eduherminio Aug 16, 2023
5a518fd
Bench with non-pow-2 values
eduherminio Aug 16, 2023
03cc343
Revert "Bench with non-pow-2 values"
eduherminio Aug 16, 2023
2b10872
Use MB for TT size configuration and print its value in logs whenever…
eduherminio Aug 16, 2023
3cb2658
Merge branch 'main' into perf/tt-size-pow-2
eduherminio Aug 16, 2023
49651f9
Adapt tests
eduherminio Aug 16, 2023
de0cffe
Fix test build
eduherminio Aug 16, 2023
2e09451
Fix TT entry printed size
eduherminio Aug 16, 2023
e9d0325
Clean up TT
eduherminio Aug 16, 2023
0b8f376
Merge branch 'main' into perf/tt-size-pow-2
eduherminio Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 176 additions & 0 deletions src/Lynx.Benchmark/TranspositionTableIndex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
/*
*
* BenchmarkDotNet v0.13.7, Windows 10 (10.0.20348.1850) (Hyper-V)
* Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
* .NET SDK 8.0.100-preview.7.23376.3
* [Host] : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX2
* DefaultJob : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX2
*
*
* | Method | size | Mean | Error | StdDev | Ratio | Allocated | Alloc Ratio |
* |------- |----------- |----------:|----------:|----------:|------:|----------:|------------:|
* | Modulo | 2097152 | 97.429 us | 1.8213 us | 1.7036 us | 1.00 | - | NA |
* | And | 2097152 | 7.107 us | 0.1393 us | 0.1710 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 4194304 | 95.984 us | 0.9829 us | 0.8713 us | 1.00 | - | NA |
* | And | 4194304 | 7.024 us | 0.1348 us | 0.1261 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 8388608 | 98.313 us | 1.9542 us | 1.9192 us | 1.00 | - | NA |
* | And | 8388608 | 7.031 us | 0.0797 us | 0.0707 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 16777216 | 96.734 us | 0.8187 us | 0.6392 us | 1.00 | - | NA |
* | And | 16777216 | 7.051 us | 0.0885 us | 0.0828 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 33554432 | 97.209 us | 1.0735 us | 1.0041 us | 1.00 | - | NA |
* | And | 33554432 | 7.214 us | 0.1191 us | 0.1114 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 67108864 | 97.015 us | 1.4319 us | 1.3394 us | 1.00 | - | NA |
* | And | 67108864 | 6.979 us | 0.0889 us | 0.0742 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 134217728 | 96.075 us | 1.2594 us | 1.1164 us | 1.00 | - | NA |
* | And | 134217728 | 6.979 us | 0.0808 us | 0.0756 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 268435456 | 96.507 us | 1.6562 us | 1.5492 us | 1.00 | - | NA |
* | And | 268435456 | 6.941 us | 0.0405 us | 0.0316 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 536870912 | 95.550 us | 0.7486 us | 0.6636 us | 1.00 | - | NA |
* | And | 536870912 | 6.987 us | 0.1078 us | 0.1008 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 1073741824 | 95.537 us | 0.9683 us | 0.8584 us | 1.00 | - | NA |
* | And | 1073741824 | 7.036 us | 0.0775 us | 0.0687 us | 0.07 | - | NA |
*
*
* BenchmarkDotNet v0.13.7, Ubuntu 22.04.3 LTS (Jammy Jellyfish)
* Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 2 logical and 2 physical cores
* .NET SDK 8.0.100-preview.7.23376.3
* [Host] : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX2
* DefaultJob : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX2
*
*
* | Method | size | Mean | Error | StdDev | Ratio | Allocated | Alloc Ratio |
* |------- |----------- |----------:|----------:|----------:|------:|----------:|------------:|
* | Modulo | 2097152 | 40.179 us | 0.0344 us | 0.0287 us | 1.00 | - | NA |
* | And | 2097152 | 7.164 us | 0.0010 us | 0.0009 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 4194304 | 40.163 us | 0.0057 us | 0.0054 us | 1.00 | - | NA |
* | And | 4194304 | 7.166 us | 0.0035 us | 0.0033 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 8388608 | 40.179 us | 0.0248 us | 0.0220 us | 1.00 | - | NA |
* | And | 8388608 | 7.164 us | 0.0014 us | 0.0011 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 16777216 | 40.166 us | 0.0038 us | 0.0036 us | 1.00 | - | NA |
* | And | 16777216 | 8.040 us | 0.0006 us | 0.0006 us | 0.20 | - | NA |
* | | | | | | | | |
* | Modulo | 33554432 | 40.166 us | 0.0054 us | 0.0046 us | 1.00 | - | NA |
* | And | 33554432 | 7.165 us | 0.0034 us | 0.0028 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 67108864 | 40.180 us | 0.0256 us | 0.0227 us | 1.00 | - | NA |
* | And | 67108864 | 7.164 us | 0.0012 us | 0.0010 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 134217728 | 40.169 us | 0.0093 us | 0.0082 us | 1.00 | - | NA |
* | And | 134217728 | 7.169 us | 0.0015 us | 0.0013 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 268435456 | 40.163 us | 0.0050 us | 0.0042 us | 1.00 | - | NA |
* | And | 268435456 | 8.041 us | 0.0013 us | 0.0011 us | 0.20 | - | NA |
* | | | | | | | | |
* | Modulo | 536870912 | 40.159 us | 0.0037 us | 0.0031 us | 1.00 | - | NA |
* | And | 536870912 | 7.168 us | 0.0008 us | 0.0007 us | 0.18 | - | NA |
* | | | | | | | | |
* | Modulo | 1073741824 | 40.167 us | 0.0137 us | 0.0114 us | 1.00 | - | NA |
* | And | 1073741824 | 8.040 us | 0.0011 us | 0.0010 us | 0.20 | - | NA |
*
*
* BenchmarkDotNet v0.13.7, macOS Monterey 12.6.7 (21G651) [Darwin 21.6.0]
* Intel Xeon CPU E5-1650 v2 3.50GHz (Max: 3.34GHz), 1 CPU, 3 logical and 3 physical cores
* .NET SDK 8.0.100-preview.7.23376.3
* [Host] : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX
* DefaultJob : .NET 8.0.0 (8.0.23.37506), X64 RyuJIT AVX
*
*
* | Method | size | Mean | Error | StdDev | Ratio | Allocated | Alloc Ratio |
* |------- |----------- |----------:|----------:|----------:|------:|----------:|------------:|
* | Modulo | 2097152 | 88.642 us | 0.3838 us | 0.3590 us | 1.00 | - | NA |
* | And | 2097152 | 5.739 us | 0.0490 us | 0.0458 us | 0.06 | - | NA |
* | | | | | | | | |
* | Modulo | 4194304 | 90.434 us | 1.7834 us | 1.7516 us | 1.00 | - | NA |
* | And | 4194304 | 5.769 us | 0.1140 us | 0.1401 us | 0.06 | - | NA |
* | | | | | | | | |
* | Modulo | 8388608 | 89.637 us | 1.7229 us | 1.9841 us | 1.00 | - | NA |
* | And | 8388608 | 5.846 us | 0.1161 us | 0.1192 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 16777216 | 90.198 us | 1.7830 us | 1.6678 us | 1.00 | - | NA |
* | And | 16777216 | 5.814 us | 0.0910 us | 0.0806 us | 0.06 | - | NA |
* | | | | | | | | |
* | Modulo | 33554432 | 90.161 us | 1.5999 us | 1.3360 us | 1.00 | - | NA |
* | And | 33554432 | 5.830 us | 0.0894 us | 0.0698 us | 0.06 | - | NA |
* | | | | | | | | |
* | Modulo | 67108864 | 90.224 us | 1.3689 us | 1.2135 us | 1.00 | - | NA |
* | And | 67108864 | 5.900 us | 0.1072 us | 0.1700 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 134217728 | 89.650 us | 1.4173 us | 1.3258 us | 1.00 | - | NA |
* | And | 134217728 | 5.863 us | 0.1158 us | 0.1334 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 268435456 | 90.653 us | 1.5062 us | 1.9585 us | 1.00 | - | NA |
* | And | 268435456 | 5.946 us | 0.1170 us | 0.1890 us | 0.07 | - | NA |
* | | | | | | | | |
* | Modulo | 536870912 | 91.520 us | 1.8254 us | 2.3735 us | 1.00 | - | NA |
* | And | 536870912 | 5.783 us | 0.1068 us | 0.0999 us | 0.06 | - | NA |
* | | | | | | | | |
* | Modulo | 1073741824 | 88.625 us | 1.6487 us | 1.3767 us | 1.00 | - | NA |
* | And | 1073741824 | 5.740 us | 0.0438 us | 0.0389 us | 0.06 | - | NA |
*
*/

using BenchmarkDotNet.Attributes;
using Lynx.Model;
using System.Numerics;
using System.Runtime.CompilerServices;

namespace Lynx.Benchmark;

public class TranspositionTableIndex : BaseBenchmark
{
public static IEnumerable<int> Data => new int[]
{
2 * 1024 * 1024,
4 * 1024 * 1024,
8 * 1024 * 1024,
16 * 1024 * 1024,
32 * 1024 * 1024,
64 * 1024 * 1024,
128 * 1024 * 1024,
256 * 1024 * 1024,
512 * 1024 * 1024,
1024 * 1024 * 1024
};

[Benchmark(Baseline = true)]
[ArgumentsSource(nameof(Data))]
public long Modulo(int size)
{
var mask = size - 1;

long total = 0;
for (long i = 0; i < 10_000L; ++i)
{
total += i % size;
}

return total + mask;
}

[Benchmark]
[ArgumentsSource(nameof(Data))]
public long And(int size)
{
var mask = size - 1;

long total = 0;
for (long i = 0; i < 10_000L; ++i)
{
total += i & mask;
}

return total + mask;
}
}
2 changes: 1 addition & 1 deletion src/Lynx.Cli/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"BishopMobilityBonus": 1,
"QueenMobilityBonus": 1,
"TranspositionTableEnabled": true,
"TranspositionTableSize": "0x10000000", // 256 MB
"TranspositionTableSize": "256",
"UseOnlineTablebaseInRootPositions": false,
"UseOnlineTablebaseInSearch": false,
"BenchDepth": 5
Expand Down
50 changes: 37 additions & 13 deletions src/Lynx.Dev/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using Lynx.Internal;
using Lynx.Model;
using System.Diagnostics;
using System.Net.Http.Headers;
using System.Numerics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
Expand Down Expand Up @@ -47,8 +46,8 @@
//FileAndRankMasks();
//EnhancedPawnEvaluation();
//RookEvaluation();
//TranspositionTable();
UnmakeMove();
TranspositionTable();
//UnmakeMove();

#pragma warning disable IDE0059 // Unnecessary assignment of a value
const string TrickyPosition = Constants.TrickyTestPositionFEN;
Expand Down Expand Up @@ -1011,36 +1010,61 @@ static void RookEvaluation()

static void TranspositionTable()
{
var transpositionTable = new TranspositionTableElement[Configuration.EngineSettings.TranspositionTableSize];
static void TesSize(int size)
{
Console.WriteLine("Hash: {0} MB", size);
var (length, mask) = TranspositionTableExtensions.CalculateLength(size);

var lengthMb = length / 1024 / 1024;

Console.WriteLine("TT memory: {0} MB", lengthMb * Marshal.SizeOf(typeof(TranspositionTableElement)));
Console.WriteLine("TT array length: {0}MB, (0x{1}, {2} items)", lengthMb, length.ToString("X"), length);
Console.WriteLine("TT mask: 0x{0} ({1})\n", mask.ToString("X"), Convert.ToString(mask, 2));
}

Console.WriteLine($"{nameof(TranspositionTableElement)} size: {Marshal.SizeOf(typeof(TranspositionTableElement))} bytes\n");

TesSize(2);
TesSize(4);
TesSize(16);
TesSize(32);
TesSize(64);
TesSize(128);
TesSize(256);
TesSize(512);
TesSize(1024);

var (mask, length) = TranspositionTableExtensions.CalculateLength(Configuration.EngineSettings.TranspositionTableSize);
var transpositionTable = new TranspositionTableElement[length];
var position = new Position(Constants.InitialPositionFEN);
position.Print();
Console.WriteLine($"Hash: {position.UniqueIdentifier}");

var hashKey = position.UniqueIdentifier % 0x400000;
Console.WriteLine(hashKey);

var hashKey2 = TranspositionTableExtensions.TranspositionTableIndex(position, transpositionTable);
var hashKey2 = position.UniqueIdentifier & mask;
Console.WriteLine(hashKey2);

transpositionTable.ClearTranspositionTable();

//transpositionTable.RecordHash(position, depth: 3, maxDepth: 5, move: 1234, eval: +5, nodeType: NodeType.Alpha);
//var entry = transpositionTable.ProbeHash(position, maxDepth: 5, depth: 3, alpha: 1, beta: 2);

transpositionTable.RecordHash(position, targetDepth: 5, ply: 3, eval: +19, nodeType: NodeType.Alpha, move: 1234);
var entry = transpositionTable.ProbeHash(position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
transpositionTable.RecordHash(mask, position, targetDepth: 5, ply: 3, eval: +19, nodeType: NodeType.Alpha, move: 1234);
var entry = transpositionTable.ProbeHash(mask, position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
Console.WriteLine(entry); // Expected 20

transpositionTable.RecordHash(position, targetDepth: 5, ply: 3, eval: +21, nodeType: NodeType.Alpha, move: 1234);
entry = transpositionTable.ProbeHash(position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
transpositionTable.RecordHash(mask, position, targetDepth: 5, ply: 3, eval: +21, nodeType: NodeType.Alpha, move: 1234);
entry = transpositionTable.ProbeHash(mask, position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
Console.WriteLine(entry); // Expected 12_345_678

transpositionTable.RecordHash(position, targetDepth: 5, ply: 3, eval: +29, nodeType: NodeType.Beta, move: 1234);
entry = transpositionTable.ProbeHash(position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
transpositionTable.RecordHash(mask, position, targetDepth: 5, ply: 3, eval: +29, nodeType: NodeType.Beta, move: 1234);
entry = transpositionTable.ProbeHash(mask, position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
Console.WriteLine(entry); // Expected 12_345_678

transpositionTable.RecordHash(position, targetDepth: 5, ply: 3, eval: +31, nodeType: NodeType.Beta, move: 1234);
entry = transpositionTable.ProbeHash(position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
transpositionTable.RecordHash(mask, position, targetDepth: 5, ply: 3, eval: +31, nodeType: NodeType.Beta, move: 1234);
entry = transpositionTable.ProbeHash(mask, position, targetDepth: 5, ply: 3, alpha: 20, beta: 30);
Console.WriteLine(entry); // Expected 30
}

Expand Down
4 changes: 2 additions & 2 deletions src/Lynx/Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,9 @@ public sealed class EngineSettings
public bool TranspositionTableEnabled { get; set; } = true;

/// <summary>
/// 32 MB
/// MB
/// </summary>
public int TranspositionTableSize { get; set; } = 32 * 1024 * 1024;
public int TranspositionTableSize { get; set; } = 256;

public bool UseOnlineTablebaseInRootPositions { get; set; } = false;

Expand Down
16 changes: 12 additions & 4 deletions src/Lynx/Engine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public Engine(ChannelWriter<string> engineWriter)
_searchCancellationTokenSource = new();
_absoluteSearchCancellationTokenSource = new();
_engineWriter = engineWriter;

InitializeTT();
}

internal void SetGame(Game game)
Expand All @@ -51,10 +53,7 @@ public void NewGame()
AverageDepth = 0;
_isNewGameComing = true;
_isNewGameCommandSupported = true;
if (Configuration.EngineSettings.TranspositionTableEnabled)
{
_transpositionTable = new TranspositionTableElement[TranspositionTableExtensions.TranspositionTableArrayLength];
}
InitializeTT();
}

public void AdjustPosition(string rawPositionCommand)
Expand Down Expand Up @@ -275,4 +274,13 @@ public void StopSearching()
_absoluteSearchCancellationTokenSource.Cancel();
IsSearching = false;
}

private void InitializeTT()
{
if (Configuration.EngineSettings.TranspositionTableEnabled)
{
(int ttLength, _ttMask) = TranspositionTableExtensions.CalculateLength(Configuration.EngineSettings.TranspositionTableSize);
_tt = new TranspositionTableElement[ttLength];
}
}
}
2 changes: 1 addition & 1 deletion src/Lynx/LynxDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ private void HandleSetOption(string command, string[] commandItems)
{
if (commandItems.Length > 4 && int.TryParse(commandItems[4], out var value))
{
Configuration.Hash = value * 1024 * 1024;
Configuration.Hash = Math.Clamp(value, 0, 1024);
}
break;
}
Expand Down
Loading