Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET 8 #291

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Move to .NET 8 #291

merged 4 commits into from
Aug 1, 2023

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Aug 1, 2023

  • Move to .NET 8
  • Apply analysis suggestions:
    • Use Logger instead of ILogger in static classes when getting it via LogManager.GetCurrentClassLogger();
    • Improve RevertLastMove() by using [^1 instead of .Last()
    • Move to init properties for tb record, since json deserialization into record classes with init properties is only supported in .NET 8

Well, that was impressive:

8''+0.08'' - 😳

Score of Lynx 976 - net 8 vs Lynx 968 - main: 166 - 79 - 52  [0.646] 297
...      Lynx 976 - net 8 playing White: 84 - 37 - 28  [0.658] 149
...      Lynx 976 - net 8 playing Black: 82 - 42 - 24  [0.635] 148
...      White vs Black: 126 - 119 - 52  [0.512] 297
Elo difference: 104.8 +/- 37.3, LOS: 100.0 %, DrawRatio: 17.5 %
SPRT: llr 2.95 (100.2%), lbound -2.94, ubound 2.94 - H1 was accepted

Player: Lynx 976 - net 8
   "Draw by 3-fold repetition": 34
   "Draw by fifty moves rule": 6
   "Draw by insufficient mating material": 12
   "Loss: Black mates": 37
   "Loss: White mates": 42
   "No result": 6
   "Win: Black mates": 82
   "Win: White mates": 84
Player: Lynx 968 - main
   "Draw by 3-fold repetition": 34
   "Draw by fifty moves rule": 6
   "Draw by insufficient mating material": 12
   "Loss: Black mates": 82
   "Loss: White mates": 84
   "No result": 6
   "Win: Black mates": 37
   "Win: White mates": 42
Finished match

60''+1' - same 😳

Score of Lynx 976 - net 8 vs Lynx 968 - main: 160 - 77 - 67  [0.637] 304
...      Lynx 976 - net 8 playing White: 88 - 35 - 30  [0.673] 153
...      Lynx 976 - net 8 playing Black: 72 - 42 - 37  [0.599] 151
...      White vs Black: 130 - 107 - 67  [0.538] 304
Elo difference: 97.3 +/- 35.5, LOS: 100.0 %, DrawRatio: 22.0 %
SPRT: llr 2.98 (101.1%), lbound -2.94, ubound 2.94 - H1 was accepted

Player: Lynx 976 - net 8
   "Draw by 3-fold repetition": 46
   "Draw by fifty moves rule": 4
   "Draw by insufficient mating material": 17
   "Loss: Black mates": 35
   "Loss: White mates": 42
   "No result": 5
   "Win: Black mates": 71
   "Win: White makes an illegal move: a8a8": 1
   "Win: White mates": 88
Player: Lynx 968 - main
   "Draw by 3-fold repetition": 46
   "Draw by fifty moves rule": 4
   "Draw by insufficient mating material": 17
   "Loss: Black mates": 71
   "Loss: White makes an illegal move: a8a8": 1
   "Loss: White mates": 88
   "No result": 5
   "Win: Black mates": 35
   "Win: White mates": 42
Finished match

Given that settings file isn't really working for prod builds, to avoid surprises once it starts working (active pr in dotnet runtim repo)
@eduherminio eduherminio marked this pull request as ready for review August 1, 2023 13:39
@eduherminio eduherminio merged commit 51f0e75 into main Aug 1, 2023
@eduherminio eduherminio deleted the net-8 branch August 1, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant