🧹 Ponder: stop modifying GoCommand.Ponder

src/Lynx/Bench.cs

@@ -120,7 +120,7 @@ public partial class Engine
             var goCommand = new GoCommand($"go depth {depth}");
             var searchConstraints = TimeManager.CalculateTimeManagement(Game, goCommand);
 
-            var result = BestMove(goCommand, in searchConstraints);
+            var result = BestMove(in searchConstraints);
 
             var elapsedSeconds = Utils.CalculateElapsedSeconds(_stopWatch);
             totalSeconds += elapsedSeconds;

src/Lynx/Engine.cs

@@ -87,7 +87,7 @@ private void WarmupEngine()
         AdjustPosition(Constants.SuperLongPositionCommand);
 
         var searchConstrains = TimeManager.CalculateTimeManagement(Game, command);
-        BestMove(command, in searchConstrains);
+        BestMove(in searchConstrains);
 
         Bench(2);
 
@@ -152,10 +152,10 @@ public SearchResult BestMove(GoCommand goCommand)
     {
         var searchConstraints = TimeManager.CalculateTimeManagement(Game, goCommand);
 
-        return BestMove(goCommand, in searchConstraints);
+        return BestMove(in searchConstraints);
     }
 
-    public SearchResult BestMove(GoCommand goCommand, in SearchConstraints searchConstrains)
+    public SearchResult BestMove(in SearchConstraints searchConstrains)
     {
         _searchConstraints = searchConstrains;
 
@@ -171,7 +171,7 @@ public SearchResult BestMove(GoCommand goCommand, in SearchConstraints searchCon
         //SearchResult resultToReturn = await SearchBestMove(maxDepth, decisionTime);
 
         Game.ResetCurrentPositionToBeforeSearchState();
-        if (!goCommand.Ponder
+        if (!_isPondering
             && resultToReturn.BestMove != default
             && !_absoluteSearchCancellationTokenSource.IsCancellationRequested)
         {
@@ -241,12 +241,10 @@ private async ValueTask<SearchResult> SearchBestMove()
         try
         {
             _isPondering = goCommand.Ponder;
-            var searchResult = BestMove(goCommand, in searchConstraints);
+            var searchResult = BestMove(in searchConstraints);
 
             if (_isPondering)
             {
-                // Using either field or local copy for the rest of the method, since goCommand.Ponder could change
-
                 // Avoiding the scenario where search finishes early (i.e. mate detected, max depth reached) and results comes
                 // before a potential ponderhit command
                 // _absoluteSearchCancellationTokenSource.IsCancellationRequested isn't reliable because
@@ -257,9 +255,8 @@ private async ValueTask<SearchResult> SearchBestMove()
                 {
                     _isPonderHit = false;
                     _isPondering = false;
-                    goCommand.DisablePonder();
 
-                    searchResult = BestMove(goCommand, in searchConstraints);
+                    searchResult = BestMove(in searchConstraints);
                 }
             }
 

src/Lynx/UCI/Commands/GUI/GoCommand.cs

@@ -58,7 +58,7 @@ public sealed class GoCommand : IGUIBaseCommand
     public int Depth { get; }
     public int MoveTime { get; }
     public bool Infinite { get; }
-    public bool Ponder { get; private set; }
+    public bool Ponder { get; }
 
     public static int Nodes => throw new NotImplementedException();
     public static int Mate => throw new NotImplementedException();
@@ -179,6 +179,4 @@ public GoCommand(string command)
     }
 
     public static string Init() => Id;
-
-    public void DisablePonder() => Ponder = false;
 }