Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Make TT (wrapper) a readonly struct #1200

Merged

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Nov 23, 2024

This implies re-allocating the engine on Hash change, i.e. at the beginning of the execution if a different hash is chosen than the default one, something I'm not a fan of, but some prep for it was done in #1201

Only struct -> #1199

Test  | refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Elo   | 2.15 +- 1.74 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 2.89 (-2.25, 2.89) [0.00, 3.00]
Games | 65256: +18247 -17844 =29165
Penta | [1542, 7500, 14213, 7759, 1614]
https://openbench.lynx-chess.com/test/974/
Test  | refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Elo   | 1.59 +- 3.69 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 2.99 (-2.25, 2.89) [-5.00, 0.00]
Games | 14612: +4054 -3987 =6571
Penta | [355, 1685, 3149, 1772, 345]
https://openbench.lynx-chess.com/test/976/

eduherminio and others added 25 commits November 4, 2024 01:59
@eduherminio eduherminio changed the base branch from main to refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix November 26, 2024 10:20
…fix' into refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Base automatically changed from refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix to main November 26, 2024 10:21
@eduherminio eduherminio marked this pull request as ready for review November 26, 2024 17:00
@eduherminio eduherminio enabled auto-merge (squash) November 26, 2024 17:01
@eduherminio eduherminio merged commit 63d3df9 into main Nov 26, 2024
27 checks passed
@eduherminio eduherminio deleted the refactor/tt-outside-of-engine-6-readonly-struct-wrapper branch November 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant