-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ Make TT (wrapper) a readonly struct #1200
Merged
eduherminio
merged 32 commits into
main
from
refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Nov 26, 2024
Merged
⚡ Make TT (wrapper) a readonly struct #1200
eduherminio
merged 32 commits into
main
from
refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntiated at top level
…-of-engine-2-class-wrapper
…f-engine-2-class-wrapper
…-of-engine-2-class-wrapper-after-bugfix
…f-engine-5-struct-wrapper
…f-engine-2-class-wrapper-after-bugfix
eduherminio
changed the base branch from
main
to
refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
November 26, 2024 10:20
…fix' into refactor/tt-outside-of-engine-6-readonly-struct-wrapper
Base automatically changed from
refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
to
main
November 26, 2024 10:21
eduherminio
deleted the
refactor/tt-outside-of-engine-6-readonly-struct-wrapper
branch
November 26, 2024 17:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implies re-allocating the engine on Hash change, i.e. at the beginning of the execution if a different hash is chosen than the default one, something I'm not a fan of, but some prep for it was done in #1201
Only struct -> #1199