Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Make Position.UniqueIdentifier an ulong instead of a long #1078

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Oct 4, 2024

If the .NextUInt64() implementation is replaced with (ulong).NextInt64(), no bench changes

Test  | refactor/position-hash-ulong
Elo   | 1.82 +- 2.95 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=2MB
LLR   | 2.90 (-2.25, 2.89) [-3.00, 1.00]
Games | 23312: +6311 -6189 =10812
Penta | [552, 2795, 4859, 2879, 571]
https://openbench.lynx-chess.com/test/824/
Test  | main
Elo   | 0.44 +- 3.02 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=2MB
LLR   | 2.92 (-2.25, 2.89) [-5.00, 0.00]
Games | 22322: +6074 -6046 =10202
Penta | [541, 2692, 4683, 2688, 557]
https://openbench.lynx-chess.com/test/825/

@eduherminio eduherminio marked this pull request as ready for review October 4, 2024 14:06
@eduherminio eduherminio enabled auto-merge (squash) October 4, 2024 14:06
@eduherminio eduherminio merged commit f9c317c into main Oct 4, 2024
27 checks passed
@eduherminio eduherminio deleted the refactor/position-hash-ulong branch October 4, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant