Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Remove good old _isFollowingPV and _isScoringPV #1034

Merged
merged 2 commits into from
Sep 20, 2024
Merged

⚡ Remove good old _isFollowingPV and _isScoringPV #1034

merged 2 commits into from
Sep 20, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Sep 20, 2024 •
edited
Loading

Previously: #486 and #311

Score of Lynx-refactor-remove-is-following-is-scoring-pv-3997-win-x64 vs Lynx 3993 - main: 2679 - 2566 - 4156  [0.506] 9401
...      Lynx-refactor-remove-is-following-is-scoring-pv-3997-win-x64 playing White: 2005 - 634 - 2061  [0.646] 4700
...      Lynx-refactor-remove-is-following-is-scoring-pv-3997-win-x64 playing Black: 674 - 1932 - 2095  [0.366] 4701
...      White vs Black: 3937 - 1308 - 4156  [0.640] 9401
Elo difference: 4.2 +/- 5.2, LOS: 94.1 %, DrawRatio: 44.2 %
SPRT: llr 2.89 (100.0%), lbound -2.25, ubound 2.89 - H1 was accepted

@eduherminio eduherminio mentioned this pull request Sep 20, 2024
Closed
@eduherminio eduherminio marked this pull request as ready for review September 20, 2024 18:01
@eduherminio eduherminio changed the title 🧹 Attempt to get rid of _isFollowingPV and _isScoringPV II 🧹 Remove good ol _isFollowingPV and _isScoringPV Sep 20, 2024
@eduherminio eduherminio changed the title 🧹 Remove good ol _isFollowingPV and _isScoringPV 🧹 Remove good old _isFollowingPV and _isScoringPV Sep 20, 2024
@eduherminio eduherminio changed the title 🧹 Remove good old _isFollowingPV and _isScoringPV ⚡ Remove good old _isFollowingPV and _isScoringPV Sep 20, 2024
@eduherminio eduherminio merged commit 6f17244 into main Sep 20, 2024
27 checks passed
@eduherminio eduherminio deleted the refactor/remove-is-following-is-scoring-pv branch September 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eduherminio