Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant creation enhancement #798

Closed
wants to merge 37 commits into from
Closed

Variant creation enhancement #798

wants to merge 37 commits into from

Conversation

wychoong
Copy link
Contributor

@wychoong wychoong commented Jan 11, 2023 •
edited
Loading

closes #790

features

  • show variants immediately after selecting option values
  • quick edit for variant data (sku/gtin.., price, stock, backorder)

some quirks

  • option value sequence is not the same as variant's label
  • on Edit, adding new variant will take first variant's price, is this a bug or 'feature' to get same price?
  • on Edit, toggle an option value (eg: color->red) belongs to an existing variant will lost the variant data, and creating variant with same sku/gtin.. will hit unique validation error

image

Screen.Recording.2023-01-11.at.23.21.14.mov

@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 9:32am

@wychoong wychoong force-pushed the feat/variant-creation-enhancement branch from bb9ea0c to c907cfc Compare January 11, 2023 15:01
wychoong
wychoong commented Jan 16, 2023
View reviewed changes
packages/admin/tests/Unit/Jobs/Products/GenerateVariantsTest.php
Comment on lines +24 to +29
public function setUp(): void
{
parent::setUp();

$this->markTestSkipped('variant generation test should be in livewire\AbstractProduct component');
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is skipped for now and should be in AbstractProduct save

@wychoong
Copy link
Contributor Author

but for a shop with large catalogue, the staff may not remember which variant have customer group pricing enabled.

for product with few variants may not be a pain to click thru each of it to change the price
but if have variants like 10+, it will be a difficult task, and when it got a mix of variants with and without CG price in 1 product will be worst to have the changes lost in the 'table' if click on variant edit page without saving.

as this ui change is to bring some ease to quick edit sku, price, stock... etc, i think it will be nice to have CG price out there as it is part of product price

a quick poc looks like this, i think is quite ok

Screen.Recording.2023-02-24.at.19.51.07.mov

to avoid making it too complicated, this is only for during Edit, not Create

@glennjacobs glennjacobs added this to the Lunar 0.4 milestone Apr 20, 2023
@glennjacobs glennjacobs changed the title [0.3] Feat - Variant creation enhancement [0.4] Feat - Variant creation enhancement Apr 20, 2023
@glennjacobs glennjacobs marked this pull request as draft May 18, 2023 08:14
@glennjacobs
Copy link
Contributor

We still need to review this properly, but priorities have prevented it. Due to this and file conflicts, I have converted to Draft for the moment.

@glennjacobs glennjacobs changed the title [0.4] Feat - Variant creation enhancement Feat [0.4] - Variant creation enhancement May 18, 2023
@alecritson alecritson changed the title Feat [0.4] - Variant creation enhancement Variant creation enhancement May 23, 2023
@glennjacobs
Copy link
Contributor

@wychoong this is a nice improvement, but considering our ambition to move to Filament v3, can you let me know if you still want to be working on this update now? Happy to review and feedback if you do.

@wychoong
Copy link
Contributor Author

wychoong commented Jul 6, 2023

@wychoong this is a nice improvement, but considering our ambition to move to Filament v3, can you let me know if you still want to be working on this update now? Happy to review and feedback if you do.

If the plan is to use Filament's form builder, I think it will be better to wait for v3.

@glennjacobs
Copy link
Contributor

@wychoong this is a nice improvement, but considering our ambition to move to Filament v3, can you let me know if you still want to be working on this update now? Happy to review and feedback if you do.

If the plan is to use Filament's form builder, I think it will be better to wait for v3.

OK, I will close this PR then. Thanks.

@glennjacobs glennjacobs closed this Jul 6, 2023
@glennjacobs
Copy link
Contributor

@wychoong Due to timeframes and client commitments, we would like to continue this development. Would you like to work on it, or shall we take over the development?

@glennjacobs glennjacobs reopened this Aug 21, 2023
@wychoong
Copy link
Contributor Author

@wychoong Due to timeframes and client commitments, we would like to continue this development. Would you like to work on it, or shall we take over the development?

I think would be best for you to take over the development as I’m currently working on another items.

@glennjacobs
Copy link
Contributor

@wychoong Due to timeframes and client commitments, we would like to continue this development. Would you like to work on it, or shall we take over the development?

I think would be best for you to take over the development as I’m currently working on another items.

Thanks for confirming, will do.

@glennjacobs glennjacobs removed their request for review August 21, 2023 16:50
@wychoong wychoong deleted the feat/variant-creation-enhancement branch February 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecritson alecritson alecritson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Lunar 0.4
Development

Successfully merging this pull request may close these issues.

improve variants section on product creation
3 participants
@wychoong @glennjacobs @alecritson