Fix event firing for extended models #2055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when models are extended, any observers which are registered by Lunar are not taking into account by model events as the signature changes.
For example Lunar registers listeners to :
eloquent:updating: Lunar\Models\Producthowever if you had your own custom model, the signature will beeloquent:updating: App\Models\Productwhich means the observers aren't dispatched.This PR looks to override the default
fireModelEventmethod and add in an extra check to see if we're dealing with an extended model and, if so, dispatch any events for theLunar\Models\Productcounterpart.