Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to tags input #2051

Open
wants to merge 7 commits into
base: 1.x
Choose a base branch
from
Open

Improvements to tags input #2051

wants to merge 7 commits into from

Conversation

alecritson
Copy link
Collaborator

@alecritson alecritson commented Jan 2, 2025 •
edited
Loading

Addresses #2012 This PR looks to make the following changes/improvements:

  • Added helper text to tag input form component
  • Allow tags to be separated by Enter, Tab and a comma
  • Load the tags relationship when the component is hydrated as before new tags were not showing straight away when a record was updated, requiring a refresh.
  • When a tag is deleted in the panel, we now remove any taggable entries to prevent foreign key exceptions.

@alecritson alecritson requested a review from glennjacobs January 2, 2025 12:19
@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 0:19am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennjacobs glennjacobs Awaiting requested review from glennjacobs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecritson @actions-user