deps: enforce upper limit jupyter_client and pyzmq
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoepVanlier
requested review from
agom,
alessiamarcolini,
tobiasjj,
rpauszek and
aafkevandenberg
JoepVanlier
force-pushed
the
pin_jupyter_client
branch
from
8f7cdac to
39b3a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
To work around a bug in
notebookwe need to pin the upper limit ofjupyter_clientandzeromq(see jupyter/notebook#6748).Until now, we've been asking users to add these extra constraints manually, but forgetting it can lead to broken interactive notebook functionality. It's unnecessary friction when it comes to installing
pylake. Instead of adding these lines to the pip installation instructions, it's better to just add it to the requirements for the time being.When we release on
conda, we should also pin the upper limit in the recipe there.