Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FSDP distributed strategy #3026

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Added FSDP distributed strategy #3026

merged 2 commits into from
Jan 30, 2023

Conversation

tgaddair
Copy link
Collaborator 

backend:
    trainer:
        strategy: fsdp

@arnavgarg1
Copy link
Contributor

@tgaddair Should we add a test similar to this one? https://github.com/ludwig-ai/ludwig/blob/master/tests/integration_tests/test_experiment.py#L662

@tgaddair
Copy link
Collaborator Author

@arnavgarg1 unfortinately FSDP will not run on CPU. We could add such a test when we re-enable GPU tests, though!

@github-actions
Copy link

Unit Test Results

         5 files  +    1           5 suites  +1   4h 28m 40s ⏱️ + 50m 17s
  3 979 tests ±    0    3 922 ✔️ ±    0    57 💤 ±  0  0 ❌ ±0 
11 740 runs  +194  11 592 ✔️ +171  148 💤 +23  0 ❌ ±0 

Results for commit 5ada9a0. ± Comparison against base commit f687b6e.

@tgaddair tgaddair merged commit b5139c7 into master Jan 30, 2023
@tgaddair tgaddair deleted the fsdp branch January 30, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgaddair @arnavgarg1 @justinxzhao