-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input/Output Feature Schema Refactor #2147
Conversation
6354470
to
a937f5e
Compare
Most tests are passing, there is one case where I need to add a regex pattern optional argument for the string input type to handle custom fill value restrictions, but once I get that done, we should be good to go. |
273f126
to
402f19f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @connor-mccorm , overall excellent job making the Schema docs very clean and clear in Ludwig! I've got some questions, but I don't see anything blocking this from my perspective.
f9d0480
to
864b8d0
Compare
c7a405d
to
b3b64f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to wire this into the schema validation logic in a follow-up?
13f4531
to
d023a10
Compare
So I believe the schema validation logic will be using all this code now when this lands through getting each input feature marshmallow class via a |
Sounds good @connor-mccorm ! |
d42ac68
to
d578e13
Compare
d636ebe
to
4192523
Compare
cf71350
to
5affc40
Compare
for more information, see https://pre-commit.ci
Adds Marshmallow schema support for all input and output features and their corresponding preprocessing, encoders, and decoders.