fixup! remove eval on ray to fix slow eval

ludwig-ai · Sep 15, 2022 · 441580a · 441580a
1 parent c5ecc32
commit 441580a
Showing 1 changed file with 1 addition and 23 deletions.
diff --git a/ludwig/trainers/trainer_lightgbm.py b/ludwig/trainers/trainer_lightgbm.py
@@ -5,7 +5,7 @@
 import threading
 import time
 from collections import OrderedDict
-from typing import Any, Callable, Dict, Iterable, List, Optional, Tuple, Union
+from typing import Any, Dict, Iterable, List, Optional, Tuple, Union
 
 import lightgbm as lgb
 import torch
@@ -920,28 +920,6 @@ def train_step(
 
         return gbm.booster_
 
-    # def evaluation(self, dataset, dataset_name, metrics_log, tables, batch_size, progress_tracker):
-    #     from ludwig.backend.ray import _get_df_engine, RayPredictor
-
-    #     predictor_kwargs = self.executable_kwargs.copy()
-    #     if "callbacks" in predictor_kwargs:
-    #         # remove unused (non-serializable) callbacks
-    #         del predictor_kwargs["callbacks"]
-
-    #     predictor = RayPredictor(
-    #         model=self.model,
-    #         df_engine=_get_df_engine(None),
-    #         trainer_kwargs=self.trainer_kwargs,
-    #         data_loader_kwargs=self.data_loader_kwargs,
-    #         batch_size=batch_size,
-    #         **predictor_kwargs,
-    #     )
-    #     metrics, _ = predictor.batch_evaluation(dataset, collect_predictions=False, dataset_name=dataset_name)
-
-    #     append_metrics(self.model, dataset_name, metrics, metrics_log, tables, progress_tracker)
-
-    #     return metrics_log, tables
-
     def _construct_lgb_datasets(
         self,
         training_set: "RayDataset",  # noqa: F821