Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds documentation for int32 and float64 parameters on tasks #811

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

mwlang
Copy link
Contributor

@mwlang mwlang commented Oct 9, 2021

Provides documentation for the recently implemented int32 and float64 input macros on custom tasks that was merged on the lucky_task project here: luckyframework/lucky_task#3

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I haven't released a new LuckyTask that has this available, yet. I'll get this merged in after the release.

Thanks for adding this in!

@jwoertink jwoertink added the guides:next_release Wait until next release for these guides label Oct 9, 2021
@mwlang
Copy link
Contributor Author

mwlang commented Oct 9, 2021

It's the least I can do for all the contributions y'all have made to the Luck Framework.

@jwoertink jwoertink removed the guides:next_release Wait until next release for these guides label Dec 1, 2021
@jwoertink jwoertink merged commit d2e560e into luckyframework:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants