-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firefox driver #162
Add firefox driver #162
Conversation
it "can hover over an element", tags: "headless_chrome" do | ||
it "can hover over an element", tags: "headless_firefox" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we no longer test headless chrome?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point. I thought there were more headless chrome specs, but that's not true. I'll have to reinstate some of them and determine why Chrome fails. It's not working for me locally (elementary OS), and also not in a docker container. So I guess we won't be the only ones with he problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the Windows GH workflow also fails using Chrome with the same errors. So something is definitely not right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added separate specs for headless chrome and headless firefox. Chrome still fails but I'm looking into it.
Okay, it seems all tests now pass except for windows:
I've changed the chrome version in the workflow from stable to beta, which is at 123.x at the moment. Let's see if that makes it pass. |
I've enabled workflows on my fork to test the specs without having to bother you, and now they pass: https://github.com/wout/lucky_flow/actions/runs/8092510779/job/22113359024 So this should be mergeable now. |
This implements #161. I've had to jump through some hoops to make tests pass. If you could suggest better solutions, I'll happily change the code. Here's more info on changes not directly related to the Firefox driver.
Locking down at Crystal 1.5.1
Ameba wouldn't install on Crystal 1.4.1, so I had to upgrade. 1.5 is the lowest working version.
Added support for
docker compose
With the move to Go in Docker v2, the Python script
docker-compose
is now deprecated. But since it's still used quite often, I've updated the setup and test scripts to work with both versions.Using
headless_firefox
for five failing specsThe five specs tagged with
headless_chrome
that I changed consistently failed, and I couldn't make them work. Changing them toheadless_firefox
served two purposes: the errors went away, and it proved that the Firefox driver was working. Here's the full trace of theheadless_chrome
errors:Styling fixes
Ameba suggested a bunch of things, so I fixed the low-impact ones and created a to-do for the ones that need more insight.