Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can call LuckyFlow.fill_form with a select field #104

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

matthewmcgarvey
Copy link
Member

@matthewmcgarvey matthewmcgarvey commented Nov 19, 2020

Fixes #85

In the future we can add support for multiple select

session.find_elements(:css, "[flow-id]").map(&.attribute("flow-id")).uniq
session.find_elements(:css, "[flow-id]")
.map(&.attribute("flow-id"))
.compact
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selenium::Element#attribute is nilable now

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@matthewmcgarvey matthewmcgarvey merged commit cf566b3 into master Nov 24, 2020
@matthewmcgarvey matthewmcgarvey deleted the matthewmcgarvey/issue85 branch November 24, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot call LuckyFlow.fill_form with a select field
2 participants