Replace lucky env module #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Jul 6, 2021
Comment on lines
+14
to
+23
| # Example: | ||
| # ``` | ||
| # LuckyEnv.add_env :staging | ||
| # LuckyEnv.staging? # => false | ||
| # ``` | ||
| # |
There was a problem hiding this comment.
Overall, I really like this. The only thing I think that's missing is mentioning that the value comes from ENV["LUCKY_ENV"]..
There was a problem hiding this comment.
I've amended the original commit. See 6acd902.
src/web_app_skeleton/config/env.cr
Outdated
| @@ -1,20 +1,29 @@ | |||
| module Lucky::Env | |||
| extend self | |||
| # Lucky manages environments using `LuckyEnv`. By default, development, | |||
There was a problem hiding this comment.
Can we add a link to the lucky_env github repo?
There was a problem hiding this comment.
I adjusted the documentation in 6acd902. However, instead of linking to the GitHub repository, I link to the configuration section of the Lucky documentation. I thought that would be more helpful. What do you think? 🙂
hovsater
force-pushed
the
replace-lucky-env-module
branch
from
c9b9931 to
5ffc579
Compare
|
I've released v0.1.3 of LuckyEnv. No shard.yml update should be needed. I think it'll just pick it up. |
|
@jwoertink thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to replace the
Lucky::Envmodule withLuckyEnv. I was not entirely sure how we want to go about structuring theenv.crfile. So any feedback is appreciated. 🙂Closes #654.