Replace normalize-scss with modern-normalize
#652
Conversation
|
Connected to #640 You might check out our conversation there. Not sure if it will change what you did at all |
|
Thanks for that. I did miss the previous conversation. I still think it makes sense to ship with something that ensures a consistent experience across the latest version of the most popular browsers. This allow a decent experience out of the box for MVPs and prototypes. Larger projects will most likely have their own opinionated way of working and can easily swap this out. This of course, is just my take. I'm happy to discuss it further. 🙂 |
There was a problem hiding this comment.
I don't personally know the differences here, but I'm cool with this change 👍 I agree that shipping with something that just gives it a little "polish" touch is nice.
Do we need to look at any changes to any styles or markup that's generated from default apps?
|
@stephendolan @paulcsmith I'd like to get your input on this. Both of you handle front-end stuff way more than I. |
|
This is definitely an improvement. I think we should merge to get rid of the deprecation warning. Maybe we could remove it altogether in the future, but that can be discussed separately. |
normalize-scss hasn't had an update in three years and its pretty unlikely the following deprecation warning will be fixed any time soon.
sindresorhus maintains modern-normalize and its regularly kept up-to-date. It's not a 1-1 replacement though, see https://github.com/sindresorhus/modern-normalize#differences-from-normalizecss for details.
Personally, I think it's a fair trade off. If you need something more sophisticated, it's easy enough to swap out.