Default to printing emails to logs in development #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Sep 25, 2020
This PR aims to make debugging emails a bit more straightforward for more Lucky users. I remember being quite confused the first time I tried to send an email in dev, and ended up enabling SendGrid since I couldn't determine how to show the email content. Since then, I've dug into the Carbon source and found the nifty `print_emails` option when initializing a `Carbon::DevAdapter`! I think it'd be handy to turn that on by default in dev, especially since if it's too noisy turning the flag off is pretty straightforward.
jwoertink
approved these changes
Sep 25, 2020
paulcsmith
approved these changes
Sep 25, 2020
|
Will do, @jwoertink. Can't wait, that sounds super convenient @paulcsmith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make debugging emails a bit more straightforward for new Lucky users. I remember being quite confused the first time I tried to send an email in dev and ended up enabling SendGrid since I couldn't determine how to show the email content.
Since then, I've dug into the Carbon source and found the nifty
print_emailsoption when initializing aCarbon::DevAdapter! I think it'd be handy to turn that on by default in dev, especially since if it's too noisy turning the flag off is pretty straightforward.If this isn't agreeable, there are a few other options that could help (that I'm happy to open issues/PRs for):
print_emailsflag to the Carbon readmeprint_emailsflag to the Lucky guides