Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node deps #493

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Upgrade node deps #493

merged 1 commit into from
Mar 27, 2020

Conversation

paulcsmith
Copy link
Member

No description provided.

@paulcsmith paulcsmith force-pushed the pcs/upgrade-node-deps branch from a68a177 to df175a0 Compare March 26, 2020 21:25
@paulcsmith paulcsmith force-pushed the pcs/upgrade-node-deps branch from df175a0 to 719f827 Compare March 26, 2020 21:27
bdtomlin
bdtomlin approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bdtomlin bdtomlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I upgraded these dependencies in my app as well with no issues.

@paulcsmith
Copy link
Member Author

Thanks for the reviews!

@paulcsmith paulcsmith merged commit 17c2238 into master Mar 27, 2020
@paulcsmith paulcsmith deleted the pcs/upgrade-node-deps branch March 27, 2020 00:34
@bdtomlin
Copy link
Contributor

@paulcsmith, glad to help. Feel free to ping me for anything you need help with. You are doing so much, and I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkthorne jkthorne jkthorne approved these changes

@bdtomlin bdtomlin bdtomlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulcsmith @bdtomlin @jkthorne