Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VerbNoun convention for operations #386

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

paulcsmith
Copy link
Member

@paulcsmith paulcsmith commented Aug 12, 2019

Conventions make the world a better place. Let's use them :D

Closes #385

I left ResetPassword and RequestPasswordReset. I think using just a Verb in some cases. Thoughts? I was trying to figure out how to use User but forgot we still had a noun there 🤦‍♂️

Conventions make the world a better place. Let's use them :D

Closes #385
@jwoertink
Copy link
Member

Wouldn't Password be the noun? So ResetPassword still fits this convention. And in the second one a PasswordReset would be the noun, so that one also fits this convention 😉

@paulcsmith
Copy link
Member Author

I've made a huge mistake

@jwoertink
Copy link
Member

Good Gob!

@paulcsmith paulcsmith merged commit 2b3e0b4 into master Aug 12, 2019
@paulcsmith paulcsmith deleted the pcs/rename-operations branch August 12, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename operations to use VerbNoun
2 participants