Memoize current_user in actions (#508)

* Memoize current_user in BrowserAction * Clarify what memoize is doing
luckyframework · Feb 19, 2023 · 16d9ed1 · 16d9ed1
1 parent c0cc1b1
commit 16d9ed1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/api_authentication_app_skeleton/src/actions/mixins/api/auth/helpers.cr b/src/api_authentication_app_skeleton/src/actions/mixins/api/auth/helpers.cr
@@ -1,5 +1,6 @@
 module Api::Auth::Helpers
-  def current_user? : User?
+  # The 'memoize' macro makes sure only one query is issued to find the user
+  memoize def current_user? : User?
     auth_token.try do |value|
       user_from_auth_token(value)
     end

diff --git a/src/browser_app_skeleton/src/actions/browser_action.cr.ecr b/src/browser_app_skeleton/src/actions/browser_action.cr.ecr
@@ -39,7 +39,8 @@ abstract class BrowserAction < Lucky::Action
   expose current_user
 
   # This method tells Authentic how to find the current user
-  private def find_current_user(id) : User?
+  # The 'memoize' macro makes sure only one query is issued to find the user
+  private memoize def find_current_user(id) : User?
     UserQuery.new.id(id).first?
   end
   <%- end -%>