Add gzip for assets as well as server responses #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
reviewed
Dec 6, 2019
This was referenced Dec 7, 2019
Closed
bdtomlin
changed the title
bdtomlin
changed the title
paulcsmith
reviewed
Dec 13, 2019
Add explicit return type for should_compress? Co-Authored-By: Paul Smith <[email protected]>
|
@paulcsmith, all the issues have been resolved. I appreciate your patience as I learn crystal and lucky! |
paulcsmith
reviewed
Dec 14, 2019
|
There we go... |
djuber
pushed a commit
to djuber/lucky
that referenced
this pull request
Aug 29, 2021
* added static asset compression to lucky apps * settings for dynamic and static gzipping combined luckyframework#983 * added wrong branch name in dependency * only compress static assets in production * add new line to end of package.json * Update src/browser_app_skeleton/webpack.mix.js Capitalization fix Co-Authored-By: Paul Smith <[email protected]> * Update src/browser_app_skeleton/webpack.mix.js Capitalization fix Co-Authored-By: Paul Smith <[email protected]> * Update src/web_app_skeleton/config/server.cr.ecr Capitalization fix Co-Authored-By: Paul Smith <[email protected]> * Update src/web_app_skeleton/config/server.cr.ecr Capitalization fix Co-Authored-By: Paul Smith <[email protected]> * fixed some whitespace issues Co-authored-by: Paul Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Gzip Lucky::TextResponse if it's enabled #154
Description
@paulcsmith Lucky::TextResponse was definitely the right place to do this. The implementation was trivial. Once the static compression PR and this PR are merged, I will add a config file to the lucky_cli repo that enables this in new apps and contains comments that explain how it works.
Checklist
crystal tool format spec src./script/setup./script/test