Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename form to operation in resource generator #956

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Rename form to operation in resource generator #956

merged 2 commits into from
Oct 24, 2019

Conversation

vlazar
Copy link
Contributor

@vlazar vlazar commented Oct 24, 2019

Fixes #946

jwoertink
jwoertink requested changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Just a small change, and then it should be good.

tasks/gen/templates/resource/pages/{{folder_name}}/edit_page.cr.ecr Outdated Show resolved Hide resolved
tasks/gen/templates/resource/pages/{{folder_name}}/new_page.cr.ecr Outdated Show resolved Hide resolved
@vlazar vlazar requested a review from jwoertink October 24, 2019 16:24
jwoertink
jwoertink approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulcsmith paulcsmith merged commit 446a545 into luckyframework:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource generator should rename form to operation
3 participants
@vlazar @jwoertink @paulcsmith